Open
Conversation
Fixed error with get_devices() It returned Error 400
Contributor
|
I checked a few minutes ago and version in |
|
Actually I had the same problem as (Snusmumrick), I managed to get it fixed by adding GET Parameters to the (api/user/device) Request ( find attached code ). And the commit is necessary for the app to get the devices list. Maybe the api response is country dependant ! |
|
In my testing I found that, when getting the list of devices, by sending params to /api/user/device:
So be careful and consistent. This PR is pretty ugly though, URL parameters should be sent using the params keyword in requests.get(), not just appending to the URL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed error with get_devices()
It returned Error 400